Open
Conversation
teemuvesala
reviewed
Feb 15, 2021
Dockerfile_distroless
Outdated
| echo $(echo BUILD_TIME_ALPINE_VERSION: && /bin/cat /etc/alpine-release) && \ | ||
| pip install -r /tmp/requirements.txt && \ | ||
| mkdir /app | ||
| COPY ./entrypoint.sh /app/entrypoint.sh |
Contributor
There was a problem hiding this comment.
I suppose entrypoint.sh is not needed anymore. So remove that file and this line please.
Contributor
Author
There was a problem hiding this comment.
Done. Removed also other not needed lines
Contributor
Author
|
@teemuvesala now needed changes is done |
teemuvesala
approved these changes
Feb 15, 2021
chaggeus
commented
Feb 15, 2021
Contributor
Author
chaggeus
left a comment
chaggeus
left a comment
There was a problem hiding this comment.
@teemuvesala added similarity to both implementation (apine and distroless based docker images). Merge and remove branch if you are happy with these.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made testing with distroless container images and get it working.
With this lets create new tag to image e.g.:
theprojectaurora/k8s-http-request-mirror:distroless-latest